fix(shared): Parse string value including a leading number as string value #4946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
defineCustomElement
usestoNumber
to parse the attribute value and check if the value is number or not.Currently, toNumber uses parseFloat and returns number value if parseFloat does not return a NaN.
However, parseFloat does not parse strictly, values including chars other than numbers will also be parsed as Number.
According to MDN, it is better to use Number() for strict parsing, so I created this PR.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat
Changes
Number(value)
playground